Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Propagate context on Manager.Start(...) #1205

Merged
merged 1 commit into from Oct 2, 2020
Merged

⚠️ Propagate context on Manager.Start(...) #1205

merged 1 commit into from Oct 2, 2020

Commits on Oct 2, 2020

  1. ⚠️ Propagate context on Manager.Start(...) 

    This change reshuffles how the manager accepts and operates on
a context. With this change, the user experience is greatly improved,
users can now use `ctrl.SetupSignalHandler()` to create a context, enrich
it if they want to, and pass it to `manager.Start`.

In addition, this PR changes how the context and stop channel are
handled internally to ensure proper cancellation.

Signed-off-by: Vince Prignano <vincepri@vmware.com>
    @vincepri
    vincepri committed Oct 2, 2020
    Copy the full SHA
    0f46012 View commit details
    Browse the repository at this point in the history