⚠️ Envtest should modify CRDs appropriately when using webhooks #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
vincepri
changed the title
k8s-ci-robot
added
approved
DirectXMan12
suggested changes
May 14, 2021
vincepri
force-pushed
the
envtest-conversion-webhook
branch
2 times, most recently
from
0080db8
to
33d8c2e
Compare
k8s-ci-robot
added
size/M
vincepri
force-pushed
the
envtest-conversion-webhook
branch
2 times, most recently
from
e2d06be
to
761e005
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before this change, the webhook code was patching mutation or admission webhooks to point to the temporary URL and CA bundle generated when the webhook server would start. Conversion webhooks are handled at the CRD level in Kubernetes, and we need to make sure to patch those client configurations as well. This patch also unexports a lot of methods that should have been private from the very beginning, so it's marked as a breaking change. Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
envtest-conversion-webhook
branch
from
761e005
to
2bfe5cf
Compare
k8s-ci-robot
removed
the
lgtm
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the webhook code was patching mutation or admission
webhooks to point to the temporary URL and CA bundle generated when the
webhook server would start.
Conversion webhooks are handled at the CRD level in Kubernetes, and we
need to make sure to patch those client configurations as well.
This patch also unexports a lot of methods that should have been private
from the very beginning, so it's marked as a breaking change.
Signed-off-by: Vince Prignano vincepri@vmware.com
/assign @alvaroaleman @DirectXMan12