Merge pull request #1970 from Tomy2e/panic-conversion-webhook

🐛 Conversion webhook should not panic when conversion request is nil
kubernetes-sigs · Sep 26, 2022 · 78b203b · 78b203b
2 parents c83076e + 07ba0bc
commit 78b203b
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pkg/webhook/conversion/conversion.go b/pkg/webhook/conversion/conversion.go
@@ -69,6 +69,12 @@ func (wh *Webhook) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	if convertReview.Request == nil {
+		log.Error(nil, "conversion request is nil")
+		w.WriteHeader(http.StatusBadRequest)
+		return
+	}
+
 	// TODO(droot): may be move the conversion logic to a separate module to
 	// decouple it from the http layer ?
 	resp, err := wh.handleConvertRequest(convertReview.Request)