fixup! Envtest Binary Version Manager Tool

kubernetes-sigs · Apr 28, 2021 · 4c19778 · 4c19778
1 parent a70e98d
commit 4c19778
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tools/setup-envtest/env/env.go b/tools/setup-envtest/env/env.go
@@ -448,8 +448,6 @@ func (e *Env) PathMatches(value string) bool {
 	e.Platform.Arch = "*"
 	e.manualPath = value
 	return true
-
-	return false
 }
 
 // versionFromPathName checks if the given path's last component looks like one

diff --git a/tools/setup-envtest/main.go b/tools/setup-envtest/main.go
@@ -102,6 +102,8 @@ func setupEnv(globalLog logr.Logger, version string) *envp.Env {
 	case "", "latest":
 		env.Version = versions.LatestVersion
 	case "latest-on-disk":
+		// we sort by version, latest first, so this'll give us the latest on
+		// disk (as per the contract from env.List & store.List)
 		env.Version = versions.AnyVersion
 		env.NoDownload = true
 	default: