set fields before injecting in controllerManager

kubernetes-sigs · May 1, 2021 · 21ac80f · 21ac80f
1 parent 8b3b421
commit 21ac80f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/manager/internal.go b/pkg/manager/internal.go
@@ -225,6 +225,9 @@ func (cm *controllerManager) Add(r Runnable) error {
 
 // Deprecated: use the equivalent Options field to set a field. This method will be removed in v0.10.
 func (cm *controllerManager) SetFields(i interface{}) error {
+	if err := cm.cluster.SetFields(i); err != nil {
+		return err
+	}
 	if _, err := inject.InjectorInto(cm.SetFields, i); err != nil {
 		return err
 	}
@@ -234,9 +237,6 @@ func (cm *controllerManager) SetFields(i interface{}) error {
 	if _, err := inject.LoggerInto(cm.logger, i); err != nil {
 		return err
 	}
-	if err := cm.cluster.SetFields(i); err != nil {
-		return err
-	}
 
 	return nil
 }