Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Upgrade golang version (1.18.3 -> 1.19.0) #7135

Merged
merged 1 commit into from Sep 1, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Aug 30, 2022

What this PR does / why we need it:

Upgrade golang version 1.18.3 -> 1.19.0 as required by v1.25.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6661

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2022
@sbueringer
Copy link
Member

sbueringer commented Aug 31, 2022

@oscr Can you please also update the go version in v.12-to-v1.3.md?

(I'll re-run the presubmits once the last finding on the test-infra PR is fixed and the test-infra PR is merged)

@oscr
Copy link
Contributor Author

oscr commented Aug 31, 2022

@sbueringer Done. I didn't bump go.mod since it's still on 1.17. Do want it upgraded?

@sbueringer
Copy link
Member

@sbueringer Done. I didn't bump go.mod since it's still on 1.17. Do want it upgraded?

I think it's fine when we bump it when we actually bump our Go dependencies in #7123 (or as a follow-up to that one)

@sbueringer
Copy link
Member

/retest

@sbueringer sbueringer mentioned this pull request Aug 31, 2022
29 tasks
@sbueringer
Copy link
Member

sbueringer commented Aug 31, 2022

/lgtm

Looks like the jobs are working now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2022
@fabriziopandini
Copy link
Member

Great Job!
/lgtm
/test pull-cluster-api-e2e-full-main

for a last check

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 896aff9 into kubernetes-sigs:main Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 1, 2022
@oscr oscr deleted the upgrade-golang-1.19 branch September 1, 2022 10:29
@ykakarap ykakarap mentioned this pull request Nov 30, 2022
13 tasks
@joekr joekr mentioned this pull request Apr 3, 2023
12 tasks
@ykakarap ykakarap mentioned this pull request May 20, 2023
13 tasks
@sbueringer sbueringer mentioned this pull request Jan 19, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants