Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] 🌱 Refresh BootstrapToken until Nodes join #6654

Merged
merged 1 commit into from
Jun 15, 2022
Merged

[release-1.1] 🌱 Refresh BootstrapToken until Nodes join #6654

merged 1 commit into from
Jun 15, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jun 15, 2022 •
edited by sbueringer

This is an automated cherry-pick of #6395

A bit more text for the PR verify action.

/assign sbueringer

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 15, 2022
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2022
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
killianmuldoon
killianmuldoon reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 🌱 [release-1.1] Refresh BootstrapToken until Nodes join #6654

@k8s-ci-robot k8s-ci-robot changed the title [release-1.1] 🌱 Refresh BootstrapToken until Nodes join 🌱 [release-1.1] Refresh BootstrapToken until Nodes join #6654 Jun 15, 2022
@killianmuldoon
Copy link
Contributor

/retitle 🌱 Refresh BootstrapToken until Nodes join

@k8s-ci-robot k8s-ci-robot changed the title 🌱 [release-1.1] Refresh BootstrapToken until Nodes join #6654 🌱 Refresh BootstrapToken until Nodes join Jun 15, 2022
@sbueringer
Copy link
Member

sbueringer commented Jun 15, 2022 •
edited

/retitle 🌱 [release-1.1] Refresh BootstrapToken until Nodes join

Let's please keep the prefix. We adjusted the verify action and the release note generation tool accordingly lately.

xref: #6160

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Refresh BootstrapToken until Nodes join 🌱 [release-1.1] Refresh BootstrapToken until Nodes join Jun 15, 2022
@sbueringer sbueringer changed the title 🌱 [release-1.1] Refresh BootstrapToken until Nodes join [release-1.1] 🌱 Refresh BootstrapToken until Nodes join Jun 15, 2022
@killianmuldoon
Copy link
Contributor

I'm not sure how this occured in the cherry pick - but the linter is showing this needs to have its imports sorted.

@sbueringer
Copy link
Member

I'll fix it

@lentzi90 @sbueringer
🌱 Refresh BootstrapToken until Nodes join
8ea1e0f 
Previously the token was only refreshed until the infrastructure was
ready. But in some cases it can take time for the Node to join also
after this. Therefore we now wait until the Machine or MachinePool has
nodeRefs, indicating that the Node has joined.
@sbueringer sbueringer force-pushed the cherry-pick-6395-to-release-1.1 branch from 6faae55 to 8ea1e0f Compare June 15, 2022 14:16
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@sbueringer
Copy link
Member

/assign @killianmuldoon
given I added some stuff I don't want to lgtm myself

@lentzi90 lentzi90 mentioned this pull request Jun 15, 2022
Closed
@sbueringer
Copy link
Member

sbueringer commented Jun 15, 2022 •
edited

I think the problem was that git cherry-pick/merge wasn't merging in the right sorted import order somehow :)

CecileRobertMichon
CecileRobertMichon reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
killianmuldoon
killianmuldoon approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 66fb36b into kubernetes-sigs:release-1.1 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @killianmuldoon @CecileRobertMichon @lentzi90