Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 use WaitForMachinePools to configure machine pool test waits #6447

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #6446

/assign jackfrancis

@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2022
@jackfrancis
Copy link
Contributor

/retitle 馃悰 [release-1.1] use WaitForMachinePools to configure machine pool test waits

@k8s-ci-robot k8s-ci-robot changed the title [release-1.1] 馃悰 use WaitForMachinePools to configure machine pool test waits 馃悰 [release-1.1] use WaitForMachinePools to configure machine pool test waits Apr 26, 2022
@sbueringer
Copy link
Member

sbueringer commented Apr 27, 2022

/retitle 馃悰 use WaitForMachinePools to configure machine pool test waits

(for consistency with other cherry-picks)

After #6160 we can just keep the generated prefix

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot changed the title 馃悰 [release-1.1] use WaitForMachinePools to configure machine pool test waits 馃悰 use WaitForMachinePools to configure machine pool test waits Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7d05374 into kubernetes-sigs:release-1.1 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants