Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Reproduce v1alpha3=>v1beta1 upgrade issue (CR release-0.10, with leader-election) #5407

Closed
wants to merge 2 commits into from
Closed

[WIP] Reproduce v1alpha3=>v1beta1 upgrade issue (CR release-0.10, with leader-election) #5407

wants to merge 2 commits into from

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Tries to reproduce kubernetes-sigs/cluster-api-provider-aws#2834

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 7, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2021
@sbueringer sbueringer mentioned this pull request Oct 12, 2021
Closed
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-ipv6-main
(flake before even triggering the clusterctl ugprade)

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-ipv6-main
(flake before even triggering the clusterctl ugprade)

@sbueringer
Copy link
Member Author

sbueringer commented Oct 12, 2021 •
edited

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-ipv6-main 6e95c38 link false /test pull-cluster-api-e2e-ipv6-main
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Failure is expected as the IPv6 feature never has been backported to v0.3.x. So it makes sense that CAPI/CAPD v0.3.23 is not able to create a IPv6 cluster (note: the IP_FAMILY env var is not really used but the IPv6 CIDRs are used [yaml])

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2021
@sbueringer sbueringer changed the title [WIP] Reproduce v1alpha3=>v1beta1 upgrade issue [WIP] Reproduce v1alpha3=>v1beta1 upgrade issue (mgr refactor, with leader-election) Nov 3, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fabriziopandini after the PR has been reviewed.
You can assign the PR to them by writing /assign @fabriziopandini in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer mentioned this pull request Nov 3, 2021
Merged
@sbueringer sbueringer changed the title [WIP] Reproduce v1alpha3=>v1beta1 upgrade issue (mgr refactor, with leader-election) [WIP] Reproduce v1alpha3=>v1beta1 upgrade issue (CR release-0.10, with leader-election) Nov 5, 2021
@sbueringer
Copy link
Member Author

Testing kubernetes-sigs/controller-runtime#1690 now

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer mentioned this pull request Nov 5, 2021
Merged
@sbueringer
Copy link
Member Author

/close
Bug has been fixed in CR main and release-0.10.

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close
Bug has been fixed in CR main and release-0.10.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbueringer @k8s-ci-robot