🐛 capd: don't add host ports to exposed ports of containers

[schrej]

This fixes an issue when running capd with podmans docker compatibility mode. And it's also incorrect in general.

What this PR does / why we need it:
CAPD currently adds the host ports that are part of a port mapping to the list of 'exposed ports' of the container. This is incorrect and leads to an error when using CAPD with podman, since capd sets the host port to 0 so an available port is automatically selected.

controller.go:324] "Reconciler error" err="failed to create load balancer: error creating container \"capi-quickstart-lb\": Error response from daemon: fill out specgen: port numbers must be between 1 and 65535 (inclusive), got 0" controller="dockercluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="DockerCluster"

There is no specific documentation around this that I could find. The closest is this: moby/moby#3039

This took way to long 😄

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[schrej]

/area provider/infrastructure-docker

[chrischdi]

Can you please add the error when using CAPD with podman in the description?

This helps to verify in future to verify if the same issue occurs again.

[schrej]

done

[chrischdi]

/test help

[k8s-ci-robot]

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-cluster-api-build-main
• /test pull-cluster-api-e2e-blocking-main
• /test pull-cluster-api-e2e-conformance-ci-latest-main
• /test pull-cluster-api-e2e-conformance-main
• /test pull-cluster-api-e2e-main
• /test pull-cluster-api-e2e-mink8s-main
• /test pull-cluster-api-e2e-upgrade-1-30-1-31-main
• /test pull-cluster-api-test-main
• /test pull-cluster-api-test-mink8s-main
• /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-apidiff-main
• pull-cluster-api-build-main
• pull-cluster-api-e2e-blocking-main
• pull-cluster-api-test-main
• pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[chrischdi]

/test pull-cluster-api-e2e-main

[chrischdi]

/lgtm

I think this PR makes sense as is. Thanks @schrej !

Looks like podman is a bit more correct on its api / docker a bit more lazy :-)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 8de191905bd15b8f244d03ed32c42bf27846ba14

[sbueringer]

Thx!

Looks good to me and tests are green so

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment