Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix pod kube-api-access sa not found #352

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

yoonmac
Copy link
Contributor

@yoonmac yoonmac commented Sep 8, 2023

What this PR does / why we need it:
Currently, #348 PodKubeAPIAccessMutatorPlugin not works and will get "error looking up serviceAccount ...." error, this PR will fix this issue

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yoonmac / name: zxpan (934fd10)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yoonmac
Once this PR has been reviewed and has the lgtm label, please assign fei-guo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @yoonmac!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-nested 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-nested has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yoonmac. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2023
@yoonmac yoonmac changed the title fix pod kube-api-access sa not found 🐛 fix pod kube-api-access sa not found Sep 8, 2023
@yoonmac
Copy link
Contributor Author

yoonmac commented Sep 12, 2023

Hi @christopherhein could you please take a look at this pr? Thanks

@Fei-Guo
Copy link

Fei-Guo commented Sep 12, 2023

@wondywang , please take a look.

@christopherhein
Copy link
Member

@yoonmac can you make sure you sign the CLA too?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2023
@yoonmac yoonmac force-pushed the projected-sa branch 2 times, most recently from a92297e to f35957a Compare September 12, 2023 11:53
@yoonmac
Copy link
Contributor Author

yoonmac commented Sep 12, 2023

@yoonmac can you make sure you sign the CLA too?

/ok-to-test

@christopherhein I have signed the CLA, now the commit can link to my profile.

@yoonmac
Copy link
Contributor Author

yoonmac commented Sep 17, 2023

@wondywang , please take a look. Thanks

@wondywang
Copy link
Contributor

This does seem to be a bug. I implement it internally based on the Admission plugin. Something went wrong with the conversion process. Many thanks to @yoonmac for pointing out this mistakes.

/lgtm

cc @Fei-Guo @christopherhein

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@yoonmac
Copy link
Contributor Author

yoonmac commented Sep 18, 2023

@yoonmac can you make sure you sign the CLA too?
/ok-to-test

@christopherhein I have signed the CLA, now the commit can link to my profile.

@christopherhein could you please help trigger the cla bot? thanks

@Fei-Guo
Copy link

Fei-Guo commented Sep 18, 2023

/ok-to-test

@yoonmac
Copy link
Contributor Author

yoonmac commented Sep 19, 2023

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 19, 2023
@yoonmac
Copy link
Contributor Author

yoonmac commented Sep 26, 2023

@Fei-Guo Could you please help approve and merge? I need a new release version based on main. Thanks

@Fei-Guo Fei-Guo merged commit a995945 into kubernetes-sigs:main Sep 26, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants