Only add new conditions to a VC's .status.conditions #349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the current implementation, there can be a large number of redundant conditions with the identical
Reason
,Message
andStatus
in a VC's.Status.Conditions
. A large number of duplicated conditions can cause potential performance issues. It's hard to read too.This PR makes a change on how to add a VC's condition to
.Status.Conditions
. It checks whether a new condition exits byReason
andStatus
and adds the condition only when it does not exist. if the condition already exists, it will only update the condition'slastTransitionTime
. It sets.Conditions.Status
value too.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #