Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Bump CAPI to v1.6.5 #4856

Merged
merged 2 commits into from
May 17, 2024

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI to v1.6.5.

Which issue(s) this PR fixes:

N/A, but see #4742 for prior art.

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Bump CAPI to v1.6.5

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.65%. Comparing base (3c1bb0a) to head (394d5c9).
Report is 3 commits behind head on release-1.14.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.14    #4856   +/-   ##
=============================================
  Coverage         62.65%   62.65%           
=============================================
  Files               192      192           
  Lines             15694    15694           
=============================================
  Hits               9833     9833           
  Misses             5174     5174           
  Partials            687      687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma mboersma added this to the v1.16 milestone May 15, 2024
@mboersma
Copy link
Contributor Author

/test ls

@k8s-ci-robot
Copy link
Contributor

@mboersma: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
  • /test pull-cluster-api-provider-azure-build-v1beta1
  • /test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
  • /test pull-cluster-api-provider-azure-e2e-aks-v1beta1
  • /test pull-cluster-api-provider-azure-e2e-v1beta1
  • /test pull-cluster-api-provider-azure-e2e-workload-upgrade-v1beta1
  • /test pull-cluster-api-provider-azure-test-v1beta1
  • /test pull-cluster-api-provider-azure-verify-v1beta1

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-azure-apidiff-v1beta1
  • /test pull-cluster-api-provider-azure-capi-e2e-v1beta1
  • /test pull-cluster-api-provider-azure-conformance-v1beta1
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-v1beta1
  • /test pull-cluster-api-provider-azure-e2e-optional-v1beta1

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-azure-apidiff-v1beta1
  • pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
  • pull-cluster-api-provider-azure-build-v1beta1
  • pull-cluster-api-provider-azure-capi-e2e-v1beta1
  • pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
  • pull-cluster-api-provider-azure-e2e-aks-v1beta1
  • pull-cluster-api-provider-azure-e2e-v1beta1
  • pull-cluster-api-provider-azure-test-v1beta1
  • pull-cluster-api-provider-azure-verify-v1beta1

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-workload-upgrade-v1beta1

@mboersma
Copy link
Contributor Author

/retest

@nojnhuh
Copy link
Contributor

nojnhuh commented May 16, 2024

In case you haven't already tracked down the upgrade test failure, I think it's because we should have backported #4715 change but didn't. I had the bot open #4857 to cherry-pick that.

@nojnhuh
Copy link
Contributor

nojnhuh commented May 16, 2024

/retest

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold like #4858 in case you wanted to squash, but this seems fine to me as-is.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9fd3a283d8fbb6466f6d7ca1ce50c6facf0a2bb6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@mboersma
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit ca369cf into kubernetes-sigs:release-1.14 May 17, 2024
20 checks passed
@mboersma mboersma deleted the capi-one-six-five branch May 17, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants