Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test integration with CAPI cluster-autoscaler #3619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test integration with CAPI cluster-autoscaler #3619

wants to merge 2 commits into from
+1,939 −34

Conversation

jackfrancis
Copy link
Contributor

@jackfrancis jackfrancis commented Jun 10, 2023 •
edited

What type of PR is this?

What this PR does / why we need it:

This PR adds test integration with the three different upstream cluster-autoscaler scenarios for Azure:

  • "azure" provider running on Azure Kubernetes in VMSS config
  • "azure" provider running on AKS in VMSS config
  • "capi" provider running on CAPZ

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

add cluster-autoscaler test scenarios

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 10, 2023
@jackfrancis
Copy link
Contributor Author

/hold

this one's not ready for merge yet!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2023
@codecov
Copy link

codecov bot commented Jun 10, 2023 •
edited

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (aa536cc) to head (93287f4).
Report is 4 commits behind head on main.

❗ Current head 93287f4 differs from pull request most recent head cd46094

Please upload reports for the commit cd46094 to get more accurate results.

Files Patch % Lines
azure/scope/managedmachinepool.go 0.00% 9 Missing ⚠️
controllers/azuremanagedmachinepool_reconciler.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
+ Coverage   62.19%   62.69%   +0.49%     
==========================================
  Files         201      192       -9     
  Lines       16878    15653    -1225     
==========================================
- Hits        10497     9813     -684     
+ Misses       5591     5156     -435     
+ Partials      790      684     -106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 5 times, most recently from 9f56992 to d40b1b2 Compare June 22, 2023 00:36
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jackfrancis. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 2 times, most recently from cd3b615 to f643c48 Compare June 22, 2023 19:55
@jackfrancis
Copy link
Contributor Author

/retest

@jackfrancis
Copy link
Contributor Author

/retest

@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 3 times, most recently from addf284 to f6ea7e9 Compare June 26, 2023 23:28
@jackfrancis
Copy link
Contributor Author

/retest

3 similar comments
@jackfrancis
Copy link
Contributor Author

/retest

@jackfrancis
Copy link
Contributor Author

/retest

@jackfrancis
Copy link
Contributor Author

/retest

@jackfrancis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

1 similar comment
@jackfrancis
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

@jackfrancis
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2024
@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 2 times, most recently from c966b06 to 10bde01 Compare February 23, 2024 22:44
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2024
@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 4 times, most recently from 4eb4fca to d454819 Compare February 29, 2024 18:48
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 29, 2024
@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 2 times, most recently from f091a0c to dcb73c1 Compare February 29, 2024 19:59
@jackfrancis jackfrancis removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024
@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 3 times, most recently from 13fe9b8 to 41c0506 Compare March 2, 2024 00:22
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2024
@jackfrancis jackfrancis force-pushed the cluster-autoscaler-e2e branch 2 times, most recently from c23a0d4 to 93287f4 Compare March 21, 2024 20:43
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2024
@jackfrancis
enable ProvisioningRequests
cd46094 
Signed-off-by: Jack Francis <jackfrancis@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@jackfrancis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-verify cd46094 link true /test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-e2e cd46094 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-capi-e2e cd46094 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e-aks cd46094 link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-conformance cd46094 link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-test cd46094 link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-apiversion-upgrade cd46094 link true /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-windows-with-ci-artifacts cd46094 link false /test pull-cluster-api-provider-azure-windows-with-ci-artifacts
pull-cluster-api-provider-azure-ci-entrypoint cd46094 link true /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-conformance-with-ci-artifacts cd46094 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts cd46094 link false /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-custom-builds cd46094 link false /test pull-cluster-api-provider-azure-conformance-custom-builds
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts cd46094 link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-windows-custom-builds cd46094 link false /test pull-cluster-api-provider-azure-windows-custom-builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@devigned devigned Awaiting requested review from devigned

@marosset marosset Awaiting requested review from marosset

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackfrancis @k8s-ci-robot @CecileRobertMichon