-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰: skip APIServerELB DNS name resolution if internal #4976
base: main
Are you sure you want to change the base?
Conversation
The check will never work in air-gapped systems.
Hi @r4f4. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@r4f4: GitHub didn't allow me to request PR reviews from the following users: mtulio, patrickdillon. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-cluster-api-provider-aws-test |
/hold |
There's a chat thread about why the DNS resolving wait code was likely there. It might be to check LB availability. Did you see problems or delays after this change, such as CAPA requiring an additional wait before reconciling further (e.g. because the LB/DNS wasn't available yet)? That's the only concern I have. Otherwise LGTM. |
When we encountered the issue we were creating a cluster in C2S via an emulator (SHIFT). The issue did not happen in another emulator (Combine). We're trying to test on a real C2S/SC2S env to determine if the internal LB name is resolvable. If so, it's an emulator bug. If not, I'll test again and pay attention to the reconcile process. |
Please also test on a real, public AWS region if you can. It would be interesting to see how removing this wait behaves, in order to find out whether it could be removed overall, or if then we need some retries for the control plane setup or so. |
I'll wait to review until hearing back on whether or not this happens in the real AWS environment. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Skip APIServerELB DNS name resolution check when the LB is internal. The check will never work in air-gapped systems.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4975
Special notes for your reviewer:
Checklist:
Release note: