Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller-runtime, controller-gen and controller-tools version for v1beta1 #2785

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Bump controller-runtime, controller-gen and controller-tools version for v1beta1 #2785

merged 1 commit into from
Oct 1, 2021

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Sep 21, 2021 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR bumps the controller runtime version to v0.10.1 which is required for v1beta1 release

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2779

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Bump controller runtime version to v0.10.1, controller-gen to v0.7.0 and controller-tools to 0.7.0  for v1beta1 release

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-priority labels Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2021
@Ankitasw Ankitasw changed the title bump controller runtime version for v1beta1 [wip] bump controller runtime version for v1beta1 Sep 21, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2021
@Ankitasw Ankitasw force-pushed the bump-cr-version branch 3 times, most recently from abd134b to 23bdafa Compare September 22, 2021 15:21
@Ankitasw
Copy link
Member Author

/retest

shivi28
shivi28 reviewed Sep 22, 2021
View reviewed changes
go.mod Outdated
k8s.io/apimachinery v0.21.4
k8s.io/api v0.22.2
k8s.io/apiextensions-apiserver v0.22.2
k8s.io/apimachinery v0.22.2
k8s.io/cli-runtime v0.21.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we are not updating cli-runtime to v0.22.2

Copy link
Member Author

@Ankitasw Ankitasw Sep 22, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have anything relevant for us in the new release? If yes we can bump that as well

Copy link
Member Author

@Ankitasw Ankitasw Sep 23, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why k8s didnt update this dependency, i ll update

@Ankitasw
Copy link
Member Author

Ankitasw commented Sep 23, 2021 •
edited

@randomvariable after changing the controller runtime version, this testEnv.Create func is changing the empty AllowedCIDRBlocks to nil , related to kubernetes-sigs/cluster-api#5249 (comment), do we still need this test then? Coz its an intentional change in controller-runtime, to change the empty structures back to nil to make sure that when you call Create, the local object doesn’t contain any data which is not returned from the server

@Ankitasw Ankitasw changed the title [wip] bump controller runtime version for v1beta1 bump controller runtime version for v1beta1 Sep 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2021
@Ankitasw Ankitasw changed the title bump controller runtime version for v1beta1 bump controller runtime and controller-tools version for v1beta1 Sep 23, 2021
@Ankitasw
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@Ankitasw: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ankitasw Ankitasw changed the title bump controller runtime and controller-tools version for v1beta1 [wip] bump controller runtime and controller-tools version for v1beta1 Sep 23, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2021
@Ankitasw Ankitasw changed the title [wip] bump controller runtime and controller-tools version for v1beta1 Bump controller-runtime, controller-gen and controller-tools version for v1beta1 Sep 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2021
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member Author

/retest

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@randomvariable
Copy link
Member

let's stop on these. there's other problems in prow atm kubernetes/test-infra#23741

@randomvariable
Copy link
Member

Also placing a
/hold

so we can do one final v0.7 release before going to v0.8

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2021
@Ankitasw
Copy link
Member Author

Ankitasw commented Sep 30, 2021 •
edited

Also placing a
/hold

so we can do one final v0.7 release before going to v0.8

Do we still need to hold this? @randomvariable

@Ankitasw Ankitasw force-pushed the bump-cr-version branch 3 times, most recently from 737a0b3 to 9f71316 Compare September 30, 2021 11:44
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@randomvariable
Copy link
Member

Hold is staying on until the next 0.7.x release.

@randomvariable
Copy link
Member

/unhold

Discussed this with @richardcase , and we're going to skip the v0.7.x release and go to v1.0.0

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2021
@randomvariable
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Oct 1, 2021
@randomvariable
Copy link
Member

/area release

@k8s-ci-robot k8s-ci-robot added the area/release Issues or PRs related to releasing label Oct 1, 2021
@randomvariable
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit b2ed789 into kubernetes-sigs:main Oct 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivi28 shivi28 shivi28 left review comments

@dthorsen dthorsen Awaiting requested review from dthorsen

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Bump controller runtime version to v0.10
4 participants
@Ankitasw @k8s-ci-robot @randomvariable @shivi28