Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When leader election is disabled controllers fail to start conversion webhooks when upgrading from v1alpha3 to v1beta1 #2834

Closed
randomvariable opened this issue Oct 7, 2021 · 6 comments
Closed

When leader election is disabled controllers fail to start conversion webhooks when upgrading from v1alpha3 to v1beta1 #2834

randomvariable opened this issue Oct 7, 2021 · 6 comments
Assignees
@randomvariable @sbueringer @fabriziopandini
Labels
area/api Issues or PRs related to the APIs kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@randomvariable
Copy link
Member

/kind bug
/kind release-blocking
/priority critical-urgent
/area api
/milestone v1.0.0

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

Tracking issue for something we're debugging in https://kubernetes.slack.com/archives/C8TSNPY4T/p1633553853231000 as part of #2833

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added this to the v1.0.0 milestone Oct 7, 2021
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/release-blocking Issues or PRs that need to be closed before the next release priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/api Issues or PRs related to the APIs needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 7, 2021
@randomvariable
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 7, 2021
@randomvariable
Copy link
Member Author

/lifecycle active
/assign
/assign @sbueringer
/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 7, 2021
@randomvariable randomvariable changed the title All CAPI controllers crash when upgrading from v1alpha3 to v1beta1 All CAPI controllers fail to start conversion webhooks when upgrading from v1alpha3 to v1beta1 Oct 7, 2021
@sbueringer sbueringer mentioned this issue Oct 7, 2021
Closed
@randomvariable randomvariable mentioned this issue Oct 7, 2021
Closed
@randomvariable randomvariable removed the kind/release-blocking Issues or PRs that need to be closed before the next release label Oct 7, 2021
@randomvariable
Copy link
Member Author

We have a workaround which is to turn leader election on. Given our release manifests have leader election on by default, this is no longer release blocking.

/milestone v1.0.x

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.0.0, v1.0.x Oct 7, 2021
@randomvariable randomvariable changed the title All CAPI controllers fail to start conversion webhooks when upgrading from v1alpha3 to v1beta1 When leader election is disabled controllers fail to start conversion webhooks when upgrading from v1alpha3 to v1beta1 Oct 7, 2021
@sbueringer sbueringer mentioned this issue Oct 13, 2021
Closed
@randomvariable
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 18, 2021
@randomvariable randomvariable removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 18, 2021
@randomvariable
Copy link
Member Author

Depends on kubernetes-sigs/controller-runtime#1685

@sbueringer
Copy link
Member

sbueringer commented Nov 10, 2021 •
edited

@randomvariable Bug has been fixed in CR.

Fix on main: kubernetes-sigs/controller-runtime#1695
Fix on release-0.10: kubernetes-sigs/controller-runtime#1690
kubernetes-sigs/controller-runtime#1685 (comment)

PR to pick up the fix in CAPI v1.0.x: kubernetes-sigs/cluster-api#5632

PR to pick up the fix in CAPI main: kubernetes-sigs/cluster-api#5633

@sedefsavas sedefsavas modified the milestones: v1.0.x, v1.1.0 Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randomvariable randomvariable

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
area/api Issues or PRs related to the APIs kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@randomvariable @sbueringer @fabriziopandini @k8s-ci-robot @sedefsavas