New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container key for function #220
Add container key for function #220
Conversation
Without this key, `kustomize build` does not adds the effect of the custom generator or transformer plugin
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @SachithKasthuriarachchi! |
CLA signed |
Thank you for the fix! I ran through the tutorial to verify, and discovered that it also has a problem where the generated dockerfile uses an image with go 1.15 but the tutorial needs go 1.16. Luckily that will be fixed automatically as soon as kubernetes-sigs/kustomize#4216 is out in the next kyaml release. So that this will show up on the site when we merge it, we'll need to regenerate the HTML. If you have hugo installed already, it's pretty easy:
Can you please add that to this PR? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, SachithKasthuriarachchi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Without this key,
kustomize build
does not add the effect of the custom generator or transformer plugin