Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CLI dependencies cobra and viper #689

Merged

Conversation

bryantbiggs
Copy link
Member

What this PR does / why we need it:

  • Update CLI dependencies cobra and viper to latest; reduces the number of transitive dependencies and patches vulnerabilities

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2024
@nnmin-aws
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2024
@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 27, 2024
@bryantbiggs
Copy link
Member Author

/retest

@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@bryantbiggs
Copy link
Member Author

/retest

@bryantbiggs
Copy link
Member Author

/retest-required

@wongma7
Copy link
Contributor

wongma7 commented Apr 22, 2024

/lgtm
/approve

will need rebase on #687 and #706

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2024
@bryantbiggs bryantbiggs force-pushed the chore/update-cli-dependencies branch from 9970884 to ebb8e5a Compare April 22, 2024 19:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@bryantbiggs
Copy link
Member Author

/retest

@bryantbiggs bryantbiggs force-pushed the chore/update-cli-dependencies branch from ebb8e5a to 06e0f6d Compare April 22, 2024 22:19
@bryantbiggs
Copy link
Member Author

cc @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Apr 25, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor

wongma7 commented Apr 25, 2024

An error occurred (NoSuchEntity) when calling the DeleteRole operation: The role with name aws-iam-authenticator-test-role-KubernetesAdmin cannot be found.

seems the role name gets reused and tests race each other.

@bryantbiggs bryantbiggs force-pushed the chore/update-cli-dependencies branch from 06e0f6d to 156a74c Compare April 25, 2024 23:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2024
@bryantbiggs
Copy link
Member Author

/retest

@wongma7
Copy link
Contributor

wongma7 commented Apr 26, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit ae0b69c into kubernetes-sigs:master Apr 26, 2024
8 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-cli-dependencies branch April 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants