Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix federated user ID parsing #644

Merged
merged 1 commit into from Nov 28, 2023
Merged

Fix federated user ID parsing #644

merged 1 commit into from Nov 28, 2023

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Nov 17, 2023 •
edited

  • refactor the parsing logic to make it easier

What this PR does / why we need it:
This PR changes the way the federated user ID is treated. Instead of splitting at a colon like we do for assumed-roles, we take the whole value. This is because if we split at the colon, the user ID is just the account number and can't be differentiated from the root user.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
SaranBalaji90
SaranBalaji90 reviewed Nov 17, 2023
View reviewed changes
pkg/token/token.go
// The user ID is one of:
// 1. UserID:SessionName (for assumed roles)
// 2. UserID (for IAM User principals).
// 3. AWSAccount:CallerSpecifiedName (for federated users)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How reliable it is, if this is a caller specified custom name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to assumed role session name, although this matches the username I think. But in the case of session name it depends how its used, if you control how a role is assumed and give the credentials to someone else then you can control the session name.

@nckturner nckturner force-pushed the fix-userid-parsing branch 5 times, most recently from 197bc18 to e70f6a8 Compare November 28, 2023 20:54
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2023
@nckturner
Fix federated user ID parsing
9fa86f7 
* refactor the parsing logic to make it easier
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2023
dims
dims approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Member

dims commented Nov 28, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7e245b into kubernetes-sigs:master Nov 28, 2023
8 checks passed
@nckturner nckturner mentioned this pull request Nov 29, 2023
Merged
nckturner added a commit that referenced this pull request Nov 29, 2023
@nckturner
Cherry-pick: Fix federated user ID parsing #644 (#654)
446ba08 
* Fix federated user ID parsing
* refactor the parsing logic to make it easier
* Update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaranBalaji90 SaranBalaji90 SaranBalaji90 left review comments

@dims dims dims approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nckturner @dims @k8s-ci-robot @SaranBalaji90