Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter dependency/security review / Do not use AWS internal image(s) #633

Merged

Conversation

dims
Copy link
Member

@dims dims commented Oct 14, 2023

  • Add new GH action for dependency review
  • Add new GH action for govulncheck
  • Use community distroless image
  • It's ok to use the golang image proxied via public ecr

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 14, 2023
@dims dims force-pushed the stricter-dependency-security-review branch from 704ea5c to a343d64 Compare October 14, 2023 23:40
@dims dims changed the title Stricter dependency/security review Stricter dependency/security review / Do not use AWS internal image(s) Oct 14, 2023
@dims dims force-pushed the stricter-dependency-security-review branch 2 times, most recently from 5b0ed22 to 3c5833c Compare October 14, 2023 23:49
@dims
Copy link
Member Author

dims commented Oct 14, 2023

/assign @nckturner @nnmin-aws

@dims dims force-pushed the stricter-dependency-security-review branch from 3c5833c to 917190e Compare October 14, 2023 23:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2023
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the stricter-dependency-security-review branch from 917190e to 2110937 Compare October 15, 2023 01:08
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@nckturner
Copy link
Contributor

What's the difference between the eks-distro and the community image?

@nnmin-aws
Copy link
Contributor

/approve

@dims dims added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dims, nnmin-aws

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 29d26f3 into kubernetes-sigs:master Oct 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants