Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jaypipes to approvers/reviewers #407

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

nckturner
Copy link
Contributor

I'd like to add Jay to the OWNERS file as an approver and reviewer so that he can take a more active role in PR reviews, as we are short staffed on this project. He needs to be added as a member of kubernetes-sigs first.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2021
@nckturner
Copy link
Contributor Author

/cc @jaypipes

@k8s-ci-robot
Copy link
Contributor

@nckturner: GitHub didn't allow me to request PR reviews from the following users: jaypipes.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jaypipes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 19, 2021
@nckturner
Copy link
Contributor Author

/verify-owners

@nckturner
Copy link
Contributor Author

Waiting on kubernetes/org#3050

@nckturner
Copy link
Contributor Author

/verify-owners

1 similar comment
@nckturner
Copy link
Contributor Author

/verify-owners

@nckturner
Copy link
Contributor Author

ok I'm confused...

@nckturner
Copy link
Contributor Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 27, 2021
@nckturner
Copy link
Contributor Author

/retest

@nckturner
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@nckturner: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wongma7
Copy link
Contributor

wongma7 commented Nov 23, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit e61f537 into kubernetes-sigs:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants