Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ./hack/install-etcd.sh #405

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Use ./hack/install-etcd.sh #405

merged 1 commit into from
Oct 20, 2021

Conversation

nckturner
Copy link
Contributor

Integration tests fail due to inability to find etcd:


Cannot find etcd, cannot run integration tests
Please see https://git.k8s.io/community/contributors/devel/sig-testing/integration-tests.md#install-etcd-dependency for instructions.

You can use 'hack/install-etcd.sh' to install a copy in third_party/.

F1011 22:22:28.628086   35042 etcd.go:173] cannot run integration tests: unable to start etcd: could not find etcd in PATH: exec: "etcd": executable file not found in $PATH
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0x1)
	/home/prow/go/pkg/mod/k8s.io/klog/v2@v2.9.0/klog.go:1026 +0x8a
k8s.io/klog/v2.(*loggingT).output(0x72d3140, 0x3, {0x0, 0x0}, 0xc00004e460, 0x0, {0x5adfbe5, 0xc0000380d0}, 0x0, 0x0)
	/home/prow/go/pkg/mod/k8s.io/klog/v2@v2.9.0/klog.go:975 +0x63d
k8s.io/klog/v2.(*loggingT).printf(0x12, 0x46719e5, {0x0, 0x0}, {0x0, 0x0}, {0x46bf398, 0x36}, {0xc0000380d0, 0x1, ...})
	/home/prow/go/pkg/mod/k8s.io/klog/v2@v2.9.0/klog.go:753 +0x1e5
k8s.io/klog/v2.Fatalf(...)
	/home/prow/go/pkg/mod/k8s.io/klog/v2@v2.9.0/klog.go:1514
k8s.io/kubernetes/test/integration/framework.EtcdMain(0xc000cbfec0)
	/home/prow/go/src/github.com/kubernetes-sigs/aws-iam-authenticator/test-artifacts/k8s.io/kubernetes/test/integration/framework/etcd.go:173 +0xcb
sigs.k8s.io/aws-iam-authenticator/tests/integration/server.TestMain(0xc000a24900)
	/home/prow/go/src/github.com/kubernetes-sigs/aws-iam-authenticator/tests/integration/server/main_test.go:37 +0x176
main.main()
	_testmain.go:45 +0x165

Attempting to use ./hack/install-etcd.sh to install it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@nckturner
Copy link
Contributor Author

/retest

@nckturner
Copy link
Contributor Author

Needed to add the policy to the awstester role in 607362164682:

{
    "Version": "2012-10-17",
    "Statement": {
        "Effect": "Allow",
        "Action": "sts:AssumeRole",
        "Resource": "arn:aws:iam::607362164682:role/aws-iam-authenticator-test-role-*"
    }
}

jaypipes
jaypipes reviewed Oct 19, 2021
View reviewed changes
hack/test-integration.sh
@@ -90,8 +90,11 @@ git clone --branch ${KUBERNETES_TAG} --depth 1 https://github.com/kubernetes/kub

pushd ${TEST_ARTIFACTS}/k8s.io/kubernetes
make generated_files
./hack/install-etcd.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you forget to add this file?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed the pushd above...

jaypipes
jaypipes approved these changes Oct 19, 2021
View reviewed changes
Copy link

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hack/test-integration.sh
@@ -90,8 +90,11 @@ git clone --branch ${KUBERNETES_TAG} --depth 1 https://github.com/kubernetes/kub

pushd ${TEST_ARTIFACTS}/k8s.io/kubernetes
make generated_files
./hack/install-etcd.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, missed the pushd above...

@jaypipes
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jaypipes: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor

wongma7 commented Oct 20, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit f58cdd7 into kubernetes-sigs:master Oct 20, 2021
@jyotimahapatra jyotimahapatra mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nckturner @jaypipes @k8s-ci-robot @wongma7