Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/token]: Update credential API version #386

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

micahhausler
Copy link
Member

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes
v1.11 (kubernetes/kubernetes#64482). At the time of this commit,
community-supported versions are v1.19, v1.20, v1.21. This change will break
for Kubernetes clients using client-go or kubectl v1.10 and earlier, which
reached end-of-life community support on Feb 13, 2019. EKS ended support
for 1.10 in September of 2019.

Kubernetes 1.22 will introduce v1 of this API, but v1beta1 will likely be
supported for a period of 2 more years.

Signed-off-by: Micah Hausler mhausler@amazon.com

Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes
v1.11 (kubernetes/kubernetes#64482). At the time of this commit,
community-supported versions are v1.19, v1.20, v1.21. This change will break
for Kubernetes clients using client-go or kubectl v1.10 and earlier, which
reached end-of-life community support on Feb 13, 2019. EKS ended support
for 1.10 in September of 2019.

Kubernetes 1.22 will introduce v1 of this API, but v1beta1 will likely be
supported for a period of 2 more years.

Signed-off-by: Micah Hausler <mhausler@amazon.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2021
Copy link

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @micahhausler

@nckturner
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, nckturner, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [micahhausler,nckturner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timfallmk
Copy link

timfallmk commented Feb 23, 2022

Might be important to make a note about changing kubeconfigs to reflect the version change. If they don't they may get the following error and not know where to go.

Unable to connect to the server: getting credentials: exec plugin is configured to use API version client.authentication.k8s.io/v1alpha1, plugin returned version client.authentication.k8s.io/v1beta1

@carl-reverb
Copy link

sed -i .bak -e 's/v1alpha1/v1beta1/' ~/.kube/config

@timfallmk
Copy link

@carl-reverb That's helpful for people that land here from google. Perhaps a quick NB on the README or release notes?

@christinax32
Copy link

@carl-reverb @timfallmk I am still getting this kubectl error after running "sed -i .bak -e 's/v1alpha1/v1beta1/' ~/.kube/config"

Unable to connect to the server: getting credentials: exec plugin is configured to use API version client.authentication.k8s.io/v1alpha1, plugin returned version client.authentication.k8s.io/v1beta1

I am using Warning: kubernetes-cli 1.23.5 already installed and aws-iam-authenticator 0.5.5

@timfallmk
Copy link

@christinax32 The only thing I can think of would be a mistype. I solved this problem by removing aws-iam-authenticator completely in favor of aws eks get-token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants