Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Improvements on the example yaml #335

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Security Improvements on the example yaml #335

merged 1 commit into from
Sep 8, 2020

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Aug 28, 2020

Sprinkling some security goodness on the example yaml file to help users do the right thing.
This change will:

  • Drop ALL capabilities
  • Enable seccomp
  • Disable privilege escalation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2020
@pjbgf
Copy link
Member Author

pjbgf commented Aug 28, 2020

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Sep 8, 2020

/lgtm
/approve
i assume allowPrivilegeEscalation: false is the default, but doesnt hurt to set it expliclty

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjbgf, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit f25a4e9 into kubernetes-sigs:master Sep 8, 2020
@pjbgf
Copy link
Member Author

pjbgf commented Sep 9, 2020

/lgtm
/approve

thank you!

i assume allowPrivilegeEscalation: false is the default, but doesnt hurt to set it expliclty

Actually, the default is actually true. 😅

Official docs: This defaults to allowed so as to not break setuid binaries...

@pjbgf pjbgf deleted the sprinkle-security-goodness branch September 9, 2020 16:30
@nckturner nckturner mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants