Fix RBAC on example file: service account requires get to ConfigMap #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign @micahhausler |
micahhausler
requested changes
Sep 2, 2020
deploy/example.yaml
Outdated
| resources: | ||
| - configmap | ||
| resourceNames: | ||
| - aws-iam-authenticator |
There was a problem hiding this comment.
It looks like the ConfigMap mapper is hard coded to watch the aws-auth, can you correct that?
There was a problem hiding this comment.
Ok, will get the example to have that changed too.
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micahhausler, pjbgf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing example yaml does not define the RBAC for getting the ConfigMap that contains the configuration.
Please note that a least privileged approach was chosen, the service account will only be able to
getthe ConfigMapaws-iam-authenticator.