Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog gen #318

Merged
merged 3 commits into from
May 15, 2020
Merged

Changelog gen #318

merged 3 commits into from
May 15, 2020

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented May 15, 2020

e.g.

$ ./hack/changelog.py \
  --token=$GITHUB_TOKEN \
  --section-title="Section Title" \
  --range=origin/master..v0.5.1-alpha.1 \
  --changelog-file=CHANGELOG.txt

and

$ cat CHANGELOG.txt

Section Title
* Fix CRD mapper blocking all others because caches never sync  and revamp backend-mode flag ([#303](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/303), @wongma7)
* Update aws-sdk-go to version v1.30.0 ([#306](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/306), @nckturner)
* Bump k8s.io/ dependencies to 1.16.8 ([#305](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/305), @wongma7)
* chown aws-iam-authenticator to avoid permission denied ([#302](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/302), @wongma7)
* Indentation and unit test improvements ([#298](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/298), @bhagwat070919)
* Adding Rate limiting ec2:DescribeInstances API along with Batching for high TPS ([#292](https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/292), @bhagwat070919)

(Also had to update vendor)

@nckturner nckturner requested a review from wongma7 May 15, 2020 06:20
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2020
@wongma7
Copy link
Contributor

wongma7 commented May 15, 2020

cool!

@wongma7
Copy link
Contributor

wongma7 commented May 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2020
@christopherhein
Copy link
Member

christopherhein commented May 15, 2020

Nice and this could be piped into goreleaser as the release notes. https://goreleaser.com/customization/release/#custom-release-notes

CHANGELOG.md Show resolved Hide resolved
@wongma7
Copy link
Contributor

wongma7 commented May 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6e9918f into kubernetes-sigs:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants