Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples/README #317

Merged
merged 1 commit into from
May 18, 2020

Conversation

otterley
Copy link
Contributor

Update the examples and README file to help users avoid issues caused by failing to quote template macros where necessary; and to further document the behavior of {{SessionName}} vs. {{SessionNameRaw}}.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2020
@otterley
Copy link
Contributor Author

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented May 15, 2020

/lgtm
thanks. Looking into the test failures.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2020
@wongma7
Copy link
Contributor

wongma7 commented May 15, 2020

/retest
pretty sure prow does not respect this for travis jobs but trying anyway

@wongma7 wongma7 closed this May 15, 2020
@wongma7 wongma7 reopened this May 15, 2020
@therc
Copy link

therc commented May 18, 2020

Thanks, I just wasted more than an hour debugging issues and I would have wasted even more if I hadn't seen this PR and the mention of the quotes.

@wongma7
Copy link
Contributor

wongma7 commented May 18, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otterley, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2a7c4a5 into kubernetes-sigs:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants