Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some six usage #2224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove some six usage #2224

wants to merge 1 commit into from

Conversation

a-detiste
Copy link

@a-detiste a-detiste commented May 3, 2024 •
edited

/kind cleanup

six was only needed to also support Python2 with the same codebase.

https://wiki.debian.org/Python3-six-removal

I will continue if this first one succeeds.

grep 'six.iteritems(self.openapi_types)' -rl | while read f do
    sed -i 's|six.iteritems(self.openapi_types)|self.openapi_types.items()|' $f
done

pyflakes3 . | grep "'six' imported but unused" | cut -d: -f1 | while read f do
    sed -i '/^import six$/d' $f
done

@a-detiste
remove some six usage
bb6bcf1 
grep 'six.iteritems(self.openapi_types)' -rl | while read f
do
    sed -i 's|six.iteritems(self.openapi_types)|self.openapi_types.items()|' $f
done

pyflakes3 . | grep "'six' imported but unused" | cut -d: -f1 | while read f
do
    sed -i '/^import six$/d' $f
done
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 3, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 3, 2024 •
edited

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @a-detiste!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw May 3, 2024 13:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: a-detiste
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from yliaog May 3, 2024 13:34
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 3, 2024
roycaihw
roycaihw reviewed May 8, 2024
View reviewed changes
kubernetes/client/models/admissionregistration_v1_service_reference.py
@@ -13,7 +13,6 @@
import pprint
import re # noqa: F401

import six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is generated by openapi-generator. The change needs to be made upstream. Otherwise the change will be override when we re-generate the client

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think it's already gone. OpenAPITools/openapi-generator#16675
Wait & see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a-detiste @k8s-ci-robot @roycaihw