Don't delete all nodes when empty string is passed

[herlo]

Fixed a bug that allows an empty string for a node name when calling the delete_node/delete_node_with_http_info method.

What type of PR is this?

/kind bug

What this PR does / why we need it:

#2209 explains the issue well.

Which issue(s) this PR fixes:

Fixes #2209

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

• ✅login: herlo / (124e73b)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @herlo!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: herlo
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[herlo]

/release-note-none

[roycaihw]

This behavior is probably happening for all APIs in this client.

We are discussing if this is expected behavior or something we want to change. One idea is such an empty string validation can happen at a higher level.

/cc @yliaog @roycaihw @lumingx

[k8s-ci-robot]

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: lumingx.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This behavior is probably happening for all APIs in this client.

We are discussing if this is expected behavior or something we want to change. One idea is such an empty string validation can happen at a higher level.

/cc @yliaog @roycaihw @lumingx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[roycaihw]

@herlo Could you verify if this behavior applies to other APIs as well? If so, it's probably unrealistic to patch all the delete methods in this client.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.