-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds UTC defaults to TimezoneInfo class constructor #2167
Adds UTC defaults to TimezoneInfo class constructor #2167
Conversation
|
Welcome @kpitzen! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kpitzen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup |
@@ -18,7 +18,7 @@ | |||
|
|||
|
|||
class TimezoneInfo(datetime.tzinfo): | |||
def __init__(self, h, m): | |||
def __init__(self, h=0, m=0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we need to default the inputs. Is there any use case? Could you elaborate a little?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
What this PR does / why we need it:
This PR offers reasonable defaults to the
TimezoneInfo
class indateutils
. The constructor itself performs input validations on these arguments, but sets the timezone name toUTC
by default - if we're defaulting internal representations of these arguments, it makes sense to allow for a default constructor to be exposed viaTimezoneInfo()
which uses those same defaults.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: