-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid shadowing important built-ins #2157
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @rafrafek! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rafrafek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please sign the CLA |
@roycaihw done! |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Bump. /remove-lifecycle stale |
What type of PR is this? cleanup(?)
What this PR does / why we need it:
Fixes a lot of potential issues when someone tries to use the code from the example.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change? NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: