-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to serialize MicroTime fields #830
Conversation
@uesyn thank you for the PR! Instead of patching the pre-process python script, can you just send a PR to this repo: I'm a maintainer on that repo so I can get that PR merged pretty quickly. That will be cleaner/easier to understand. Once that PR is in, we can rebase this one to pick up those changes and then merge this one. Thanks! |
@brendandburns Thank you for the comment! I created the PR for kuberentes/gen! I checked kubernetes/gen's master branch, and found that it's typescript's generatorName is Therefore, to generate codes with |
I rebased this PR in advance that the PR is merged. |
Thanks I LGTM'd the gen PR. You're right that we need to branch and pull it back to the commit that we use for generation, but for now let's just merge this PR also. |
@brendandburns |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, uesyn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think the next step is to run the Github action to regenerate the code. I think that we should edit the github action to cherry-pick the |
@brendandburns |
Some Kubernetes objects expect to have date fields represented RFC3339 format with microsecond.
However, Kubernetes is unable to represent microsecond field in openapi schema.
ref: kubernetes/kubernetes#97904
In this PR, patch the kubernetes/gen which generate clients based on the open api schema generated by kubernetes, and define V1MicroTime to represent microseconds.
I confirmed the below code works.
ref: #828