Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Object.ts and get unit tests runnable again #829

Conversation

davidgamero
Copy link
Contributor

Object.ts is too deeply entangled with the old ObjectSerializer and generated authentication patterns and would require a full re-write, so I am removing it from the initial migration release to streamline us back towards the primarily generated code from openapigenerator.

Otherwise mostly just import fixes and auth interface updates.
With this PR the unit tests are runnable (albeit prevalently failing) which sets up the next steps of migration in a much more manageable way for distributing work.
#755 #754

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2022
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit a510a5c into kubernetes-client:release-1.x Jun 27, 2022
@clintonmedbery
Copy link
Contributor

clintonmedbery commented May 9, 2023

@brendandburns @davidgamero I am trying to get the apply example to work again. This seems kind of impossible after removing object.ts. Do we have plans to reinstate something similar?

@davidgamero
Copy link
Contributor Author

Hey @clintonmedbery we removed object.ts to be able to fully remove the request dependency since it's so heavily dependent on it. The plan is definitely to bring back a new version built on fetch, and we'd welcome a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants