Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit references to bluebird. #199

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Remove explicit references to bluebird. #199

merged 1 commit into from
Feb 1, 2019

Conversation

brendandburns
Copy link
Contributor

Fixes #198

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2019
@drubin
Copy link
Contributor

drubin commented Jan 31, 2019

Do you think we should add a note to the readme about this change? Or is it time to add an upgrade guide too?

@ddgenome
Copy link
Contributor

This actually reverts a breaking change between 0.7.2 and 0.8.0.

@drubin
Copy link
Contributor

drubin commented Jan 31, 2019

I am aware. I was more suggesting we should try make it more visible so users can easily see.

@ddgenome
Copy link
Contributor

It would be great if this project had a CHANGELOG.md.

@drubin
Copy link
Contributor

drubin commented Feb 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2019
drubin
drubin suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@drubin drubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to update the package-lock. Json?

@k8s-ci-robot k8s-ci-robot merged commit 3a1d831 into kubernetes-client:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drubin drubin drubin requested changes

@itowlson itowlson itowlson approved these changes

Assignees

@drubin drubin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brendandburns @k8s-ci-robot @drubin @ddgenome @itowlson