chore: switch from nyc to c8 #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
I wanted to cut another RC to potentially close * #1420 * #1398 * #1397 but the release is erroring at the test because of the memory limit so I decided to use c8 instead of nyc because when trying to remove nyc I concluded that the memory error comes from it and its last release was 4 years ago. It works as a drop-in replacement. https://www.npmjs.com/package/c8
mstruebing
force-pushed
the
mstruebing/move-node-options
branch
from
a90d0f5
to
665608e
Compare
k8s-ci-robot
added
size/XXL
mstruebing
changed the title
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to cut another RC to potentially close
but the release is erroring at the test because of the memory limit
so I decided to use c8 instead of nyc because when trying to remove nyc
I concluded that the memory error comes from it and its last release was
4 years ago. It works as a drop-in replacement.
https://www.npmjs.com/package/c8
There are slight differences in the coverage reporting, what they catch as covered and uncovered, but I believe that's okay for us.
Before:
After:
