Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protocol buffers and protocol buffer dependency. #3259

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Update protocol buffers and protocol buffer dependency. #3259

merged 3 commits into from
Apr 5, 2024

Conversation

brendandburns
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2024
@codefromthecrypt
Copy link
Contributor

I'm on a spike on something I have to finish today. If this can wait until the weekend, I can sort it out no problem!

@brendandburns
Copy link
Contributor Author

@codefromthecrypt no worries, I actually have time today, I expect I'll get it straightend out. Looks like a dependency issue.

@codefromthecrypt
Copy link
Contributor

@brendandburns yep and this will fix (or is at least a workaround to) #3140. I think what's left is to copy plugin configuration that is currently required in our parent pom.xml into the examples whose parents didn't include it (e.g. spotless)

@brendandburns
Copy link
Contributor Author

Ok, I think this is ready to merge now.

This was referenced Apr 1, 2024
Closed
Closed
codefromthecrypt
codefromthecrypt approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, codefromthecrypt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 065d21a into master Apr 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brendandburns @codefromthecrypt @k8s-ci-robot