Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging dependency to e2e tests. #1481

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Add logging dependency to e2e tests. #1481

merged 1 commit into from
Mar 25, 2021

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Jan 6, 2021 •
edited

Improves logging for e2e tests.

Ref #1480

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2021
@brendandburns brendandburns mentioned this pull request Jan 6, 2021
Merged
@yue9944882
Copy link
Member

@brendandburns do we still want this? it's intended for easing flakiness which is already solved i suppose?

@brendandburns
Copy link
Contributor Author

@yue9944882 I think we do still want this. Without it the real cluster integration tests don't have any logs and so failures are really hard to debug. So I think it is worth leaving this in for future debugging of flakes or other failures.

While with unit tests it's fairly easy to debug w/o logs, the real cluster integration tests are much harder to debug that way without all of the logging that the various components do in a real system.

@brendandburns
Copy link
Contributor Author

@yue9944882 friendly ping on this PR.

Thanks!

@brendandburns
Copy link
Contributor Author

e2e flaked again:
#1574

Having these logs would make it feasible to debug such failures.

@brendandburns
Copy link
Contributor Author

@yue9944882 friendly ping on this one.

@brendandburns
Copy link
Contributor Author

@yue9944882 can I get an LGTM on this one?

yue9944882
yue9944882 reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 99bab18 into kubernetes-client:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 yue9944882 left review comments

Assignees

@yue9944882 yue9944882

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brendandburns @k8s-ci-robot @yue9944882