New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old examples use the current parent pom #3140
Comments
The issue with deleting the older examples has to do with discoverability. If it is too hard to find the older examples, people file issues when the current examples don't work with older versions of the libraries. If there is a proposal for how to achieve that (perhaps linking to git tags?) I'm open to proposals. |
I was thinking we could add a link with the release tag in the release notes to where the example is. Since the tag won't change that will always be there. another way is we could make a release asset (tar.gz or zip) with the examples, if we think people will struggle with git checkout? Basically, I think there are some considerations to find the right path.. ones I thought of are..
what do you think? |
(My proposal would be to keep only one sample and make sure release notes link to it by its version tag. That's the simplest, and we can edit the past releases to add this, too) |
if we go with my suggestion, the github action has support for a default body, so I think we can make it happen automatically (text with links to where the samples are by the git tag of that release) https://github.com/ncipollo/release-action |
Currently, the source tree holds old versions of examples. However, they use the parent-pom, which can lead to problems as we update dependencies.
I would suggest we either stop copying old versions of examples into the source tree (instead add README links to prior versions), or pin the examples to their corresponding parent poms.
For example, we could do this, but it might be better to just delete the old examples and only keep the current.
The text was updated successfully, but these errors were encountered: