Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to JDK date time library #177

Merged
merged 1 commit into from Jan 5, 2021

Conversation

dsyer
Copy link
Contributor

@dsyer dsyer commented Dec 4, 2020

Please do not merge until we finish discussing in the Java
client tracker.

See kubernetes-client/java#1411

@k8s-ci-robot
Copy link
Contributor

Welcome @dsyer!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2020
@dsyer dsyer force-pushed the javatime branch 2 times, most recently from a72c72f to 91448af Compare December 8, 2020 11:31
Signed-off-by: Dave Syer <dsyer@vmware.com>
@dsyer
Copy link
Contributor Author

dsyer commented Jan 5, 2021

This can (and should) be merged now that the Java client is using JDK time on master: kubernetes-client/java#1418

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dsyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7ba97cc into kubernetes-client:master Jan 5, 2021
@synox
Copy link

synox commented Feb 15, 2021

The pom of release 11.0.0 still contains joda-time, see https://search.maven.org/artifact/io.kubernetes/client-java-api/11.0.0/bundle

@dsyer
Copy link
Contributor Author

dsyer commented Feb 15, 2021

11.0.0 was released before this change. 12.0.0 will be the first release with JDK time I think. But I suppose that means you can't use the generator from master for a project that depends on 11.0.x? I don't know how to solve that - you probably have to use a tag or a fixed commit ID for the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants