Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add az pipepline yaml #247

Merged
merged 3 commits into from Mar 5, 2019
Merged

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Feb 25, 2019

First step to enable Azure Pipeline
Example result
https://farmer1992.visualstudio.com/opensources/_build/results?buildId=270

Built on Windows, as a result, add targeting net452 to nupkg.
However, xamarinios10, monoandroid81 still cannot be included due to that ios/android sdk are not shipped with azure pipeline image.

Need to create an instance for this report to enable azure pipeline

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2019
@@ -9,7 +9,8 @@
<PackageIconUrl>https://raw.githubusercontent.com/kubernetes/kubernetes/master/logo/logo.png</PackageIconUrl>
<PackageTags>kubernetes;docker;containers;</PackageTags>

<TargetFrameworks>netstandard1.4;net452;netcoreapp2.1;xamarinios10;monoandroid81</TargetFrameworks>
<TargetFrameworks>netstandard1.4;net452;netcoreapp2.1</TargetFrameworks>
<!-- <TargetFrameworks>netstandard1.4;net452;netcoreapp2.1;xamarinios10;monoandroid81</TargetFrameworks> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still people interested in this for xamarin, can we retain it for xamarin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure pipeline windows image does not have ios sdk on it. Build will fail only on CI.
My idea is to create another issue for it and ping Azure pipeline team.

@@ -20,7 +21,6 @@

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.JsonPatch" Version="1.1.2" />
<PackageReference Include="Nerdbank.GitVersioning" Version="2.2.33" PrivateAssets="all" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to azure pipeline versioning

  - task: DotNetCoreCLI@2
    displayName: 'dotnet pack'
    inputs:
      command: pack
      packagesToPack: src/KubernetesClient/KubernetesClient.csproj
      packDirectory: '$(Build.ArtifactStagingDirectory)/nupkg'
      majorVersion: 1
      minorVersion: 4      
      versioningScheme: byPrereleaseNumber
 this will generate a SemVer -compliant version formatted as X.Y.Z-ci-datetime where you choose X, Y, and Z.

The pro for generating version when CI is that it differentiate build and commit .
Same commit might be different due to build environment changed.

@brendandburns
Copy link
Contributor

I don't want to remove Xamarin support from the core project, perhaps we can use a script or conditional to adjust things in the pipeline build?

@tg123
Copy link
Member Author

tg123 commented Feb 27, 2019

@brendanburns fixed with conditional build. pipeline on azure will yield net452 netstandard14 netcore2.1

@RohanNagar
Copy link
Contributor

RohanNagar commented Feb 28, 2019

You should also be able to build Xamarin in Azure Pipelines, with an additional macOS build pipeline - https://docs.microsoft.com/en-us/azure/devops/pipelines/languages/xamarin?view=azure-devops

@brendandburns
Copy link
Contributor

That sounds good. Let's add a Mac build to the pipeline.

@tg123
Copy link
Member Author

tg123 commented Mar 4, 2019

If let me choose, I will choose netcore and net452 in our published nuget
and after some test, vsts macos image cannot build ios and android either.

package matrix

WinNT

  • netcoreapp2.1
  • netstandard1.4
  • net452
  • xamarinios10
  • monoandroid81

MacOS

  • netcoreapp2.1
  • netstandard1.4
  • net452
  • xamarinios10
  • monoandroid81

Ubuntu

  • netcoreapp2.1
  • netstandard1.4
  • net452
  • xamarinios10
  • monoandroid81

build using mac os
https://farmer1992.visualstudio.com/opensources/_build/results?buildId=273

@brendandburns
Copy link
Contributor

/lgtm
/approve

@tg123 what do I need to do to set this up for real?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit e0db2ae into kubernetes-client:master Mar 5, 2019
@tg123 tg123 deleted the azpipeline branch March 6, 2019 00:57
@brendandburns
Copy link
Contributor

@tg123 I finally got this setup started, but coverage is failing:

https://dev.azure.com/kubernetes-client/csharp-build/_build/results?buildId=5

Any ideas?

Thanks!

@tg123
Copy link
Member Author

tg123 commented Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants