Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage tool #228

Closed
wants to merge 43 commits into from
Closed

Conversation

sesispla
Copy link
Contributor

@sesispla sesispla commented Jan 5, 2019

It took ages... but finally this PR fixes #16

What we get (sample from my Codacy project):

Before completing this PR, there are some setup and changes from kubernetes-client owners (@brendanburns?):

  • SETUP: Add a new Codacy project for kubernetes-client
  • SETUP: Get Codacy coverage token from Coverage page
  • SETUP: Create a new TravisCI Environment Variable called CODACY_PROJECT_TOKENand add the Codacy coverage token
  • CHANGE: Change all Codacy references from my repo to Kubernetes-client (badges in readme.md, mainly).

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sesispla
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: krabhishek8260

If they are not already assigned, you can assign the PR to them by writing /assign @krabhishek8260 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 5, 2019
@sesispla
Copy link
Contributor Author

sesispla commented Jan 5, 2019

PS: The job fails because of pending tasks:

01/05 14:23:48 ERROR c.c.rules.ConfigurationRules:22 - Invalid configuration: Project token not provided and not available in environment variable "CODACY_PROJECT_TOKEN"

@brendandburns
Copy link
Contributor

Thanks! I'll see about getting this setup...

@tg123
Copy link
Member

tg123 commented Mar 22, 2019

Close as Azure pipeline setup

@tg123 tg123 closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a code coverage tool
4 participants