Update credentials for more valid values. #13
Conversation
| @@ -8,9 +9,15 @@ public class UserCredentials | |||
| [YamlMember(Alias = "client-certificate-data")] | |||
| public string ClientCertificateData { get; set; } | |||
|
|
|||
| [YamlMember(Alias = "client-certificate")] | |||
| public string ClientCertificate { get; set; } | |||
There was a problem hiding this comment.
Need to review unit tests. Thought that client-certifidate-data hold the route to a X509 certificate, but concluded now it is the certificate itself. Additional tests should be written to cover the client-certificate scenario.
| [YamlMember(Alias = "client-key-data")] | ||
| public string ClientKeyData { get; set; } | ||
|
|
||
| [YamlMember(Alias = "client-key")] | ||
| public string ClientKey { get; set; } |
There was a problem hiding this comment.
Same as client-certificate. Thought client-key-data stored a path, but they are the certificate itself. Now several tests are broken.
brendandburns
force-pushed
the
creds
branch
7 times, most recently
from
1af9978
to
f1f575e
Compare
|
@sesispla I fixed the tests. Would you like me to add new tests to this PR or as part of a later commit? |
|
@brendanburns Maybe we can add some basic tests for client-certificate-data, and then create a more intensive test plan in the future. Not perfect, but it will the job for now. For the future plan, I am looking for a Code Coverage tool in #16 which will make our life easier. |
brendandburns
force-pushed
the
creds
branch
2 times, most recently
from
f732918
to
c42d56c
Compare
brendandburns
force-pushed
the
creds
branch
3 times, most recently
from
588979c
to
bad9df9
Compare
|
@sesispla sorry for the delay. I added some tests, and then finally got them passing :) Please take another look. Thanks! |
|
@brendanburns can't see any new commits to this PR. Maybe they are in another branch? Or are they 6333784? |
|
6333784 LGTM |
|
@sesispla yeah, I squashed them down to one commit.... Thanks for the reivew! |
@sesispla @krabhishek8260
This makes it possible to use csharp with the
minikubetool.