Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pod logs core api request errors. #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed pod logs core api request errors. #227

wants to merge 1 commit into from

Conversation

homer6
Copy link
Contributor

@homer6 homer6 commented Mar 5, 2024

  1. This fix drops the text/plain header as it was causing the requests to fail entirely.
  2. This fix also moves the strdup inside the guard to prevent segfaults on null dataReceived (which I experienced and traced with gdb).

This fix is for issue #222

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: homer6
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2024
@homer6 homer6 mentioned this pull request Mar 5, 2024
Open
@ityuhui
Copy link
Member

ityuhui commented Mar 6, 2024

/hold

This PR is for review only and will not be merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
ityuhui
ityuhui reviewed Mar 6, 2024
View reviewed changes
kubernetes/api/CoreV1API.c
@@ -35170,7 +35170,7 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp
keyPairQuery_timestamps = keyValuePair_create(keyQuery_timestamps, valueQuery_timestamps);
list_addElement(localVarQueryParameters,keyPairQuery_timestamps);
}
list_addElement(localVarHeaderType,"text/plain"); //produces
//list_addElement(localVarHeaderType,"text/plain"); //produces removed text/plain as it is rejected
Copy link
Member

@ityuhui ityuhui Mar 6, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't comment this line, will the result be correct? I don't think this should affect the results.

The text/plain header is defined in the Kubernetes OpenAPI spec. This line is automatically gnereated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that header is sent, it'll respond with a 400-level instead of a 200. The comment is needed to ensure that the header is not sent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I'll try this API.

ityuhui
ityuhui reviewed Mar 6, 2024
View reviewed changes
kubernetes/api/CoreV1API.c
@@ -35193,9 +35193,11 @@ CoreV1API_readNamespacedPodLog(apiClient_t *apiClient, char *name, char *_namesp
// printf("%s\n","Unauthorized");
//}
//primitive return type simple
char* elementToReturn = strdup((char*)apiClient->dataReceived);
char* elementToReturn = NULL;
Copy link
Member

@ityuhui ityuhui Mar 6, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch !
Can you make code changes in the upstream code generator instead of here?

https://github.com/OpenAPITools/openapi-generator/blob/ae9084bfd6bf03d3ef1fff1cdb52d04b008f9621/modules/openapi-generator/src/main/resources/C-libcurl/api-body.mustache#L362

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for your reference: OpenAPITools/openapi-generator#17540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ityuhui ityuhui ityuhui left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@homer6 @k8s-ci-robot @ityuhui