Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v2.20] Update to etcd 3.5.3 for Kubernetes 1.22+ #9606

Merged
merged 3 commits into from
Apr 19, 2022
Merged

[release/v2.20] Update to etcd 3.5.3 for Kubernetes 1.22+ #9606

merged 3 commits into from
Apr 19, 2022

Conversation

embik
Copy link
Member

@embik embik commented Apr 14, 2022

What does this PR do / Why do we need it:

Manual cherry-pick of #9604 (courtesy of fixture updates). Please see original PR for details.

Does this PR close any issues?:
Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

For Kubernetes 1.22 and higher, etcd is updated to v3.5.3 to fix data consistency issues as reported by upstream developers

@embik
[release/v2.20] Update to etcd 3.5.3
22c5768 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Update fixtures
ebc969e 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2022
@embik
Copy link
Member Author

embik commented Apr 14, 2022

/hold

I want this to be verified on master / dev before merging it and putting it in a patch release.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2022
@embik
Revert unintended change to dependency
64aa9fd 
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik
Copy link
Member Author

embik commented Apr 14, 2022

/retest

@embik
Copy link
Member Author

embik commented Apr 19, 2022

/hold cancel

e2e tests look stable enough with this.

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022
@embik embik requested a review from xmudrii April 19, 2022 05:52
xmudrii
xmudrii approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ca8a075ed1d5dbc8cc19fee78c6693990126fa4

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@embik
Copy link
Member Author

embik commented Apr 19, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit b0b4cb4 into kubermatic:release/v2.20 Apr 19, 2022
@embik embik deleted the etcd-3.5.3-release/v2.20 branch October 20, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@embik @kubermatic-bot @xmudrii