New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade go-git to v5.8.0 #12487
upgrade go-git to v5.8.0 #12487
Conversation
Signed-off-by: Simon Bein <simontheleg@gmail.com>
Since we are aware of the issue this dependency update is going to fix. Can we add a release note please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold for release note. @SimonTheLeg remove the hold once the description is updated.
LGTM label has been added. Git tree hash: 1a0cd667a2aaa5603e74357d5441b12f857aaf81
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, SimonTheLeg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
good point with the release note. I have added one |
/unhold |
Keep in mind that this upgrade can be affected by: #11604
|
@pkprzekwas I think this was re-introduced in 5.6.1 |
🎉 Awesome! :-) |
What this PR does / why we need it:
We have experienced with Apps sometimes the issue described here go-git/go-git#328, which is supposed to be fixed in v5.8.0
Which issue(s) this PR fixes:
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: