[release/v1.3] Use etcd v3.5.3 for Kubernetes 1.22+ #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
release-note
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
size/S
xmudrii
reviewed
Apr 15, 2022
| @@ -52,7 +52,7 @@ const ( | |||
| ) | |||
|
|
|||
| // NewConfig returns all required configs to init a cluster via a set of v1beta3 configs | |||
| func NewConfig(s *state.State, host kubeoneapi.HostConfig) ([]runtime.Object, error) { | |||
| func NewConfig(s *state.State, host kubeoneapi.HostConfig) ([]runtime.Object, error) { //nolint:gocyclo | |||
There was a problem hiding this comment.
@kron4eg I think it's okay to ignore this lint error because:
- this is a legacy branch
- this has been already fixed in 1.4 and master
WDYT?
|
/kind bug |
kubermatic-bot
added
kind/bug
|
LGTM label has been added. Git tree hash: 74008ac6d39edad6c6228f35430ed92144d6a6e4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, kubermatic-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1951
/assign xmudrii