fix: all big enough ui proxy requests fail with error proxying with partial data #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
added
the
cherrypick-approved
|
New changes are detected. LGTM label has been removed. |
|
/lgtm |
|
@Bobgy: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jingzhang36
pushed a commit
to jingzhang36/pipelines
that referenced
this pull request
Aug 12, 2020
…artial data (kubeflow#4266) * fix: all big enough ui proxy requests fail with error proxying with partial data * Fix naming
2 tasks
jingzhang36
pushed a commit
to jingzhang36/pipelines
that referenced
this pull request
Aug 12, 2020
…artial data (kubeflow#4266) * fix: all big enough ui proxy requests fail with error proxying with partial data * Fix naming
Bobgy
added a commit
that referenced
this pull request
Aug 12, 2020
…artial data (#4266) * fix: all big enough ui proxy requests fail with error proxying with partial data * Fix naming
Jeffwan
pushed a commit
to Jeffwan/pipelines
that referenced
this pull request
Dec 9, 2020
…artial data (kubeflow#4266) * fix: all big enough ui proxy requests fail with error proxying with partial data * Fix naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
When trying out multi user mode for Kubeflow 1.1. After the cluster is up and running for a while, suddenly all big enough ui proxy requests fail with error proxying with partial data. I suspected some behavior changed for Anthos Service Mesh (istio), because I tried removing all istio sidecars, the error doesn't show up.
However, I tried troubleshooting for a while and found this hack solution from chimurai/http-proxy-middleware#171 (comment), it worked perfectly to my surprise.
Checking this in first to unblock Kubeflow 1.1 GCP release.
Checklist:
The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.
PR titles examples:
fix(frontend): fixes empty page. Fixes #1234Use
fixto indicate that this PR fixes a bug.feat(backend): configurable service account. Fixes #1234, fixes #1235Use
featto indicate that this PR adds a new feature.chore: set up changelog generation toolsUse
choreto indicate that this PR makes some changes that users don't need to know.test: fix CI failure. Part of #1234Use
part ofto indicate that a PR is working on an issue, but shouldn't close the issue when merged.Do you want this pull request (PR) cherry-picked into the current release branch?
If yes, use one of the following options:
cherrypick-approvedlabel to this PR. The release manager adds this PR to the release branch in a batch update.