Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement katib-cert-generator in Go #1662

Merged
merged 24 commits into from
Sep 15, 2021
Merged

Reimplement katib-cert-generator in Go #1662

merged 24 commits into from
Sep 15, 2021

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Sep 9, 2021 •
edited

What this PR does / why we need it:

  • Reimplement katib-cert-generator in Go.
  • Support both admission.k8s.io/v1 and admission.k8s.io/v1beta1 in ValidatingWebhookConfiguration and MutatingWebhookConfiguration.
  • Remove admission.k8s.io/v1beta1 in ValidatingWebhookConfiguration and MutatingWebhookConfiguration.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1628 #1656

@aws-kf-ci-bot
Copy link
Contributor

Hi @tenzen-y. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member Author

I removed unnecessary test codes and changed an error message.

@gaocegege
Copy link
Member

ok-to-test

gaocegege
gaocegege reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

The code is clean and elegant.

pkg/cert/v1beta1/generate/generate.go Outdated Show resolved Hide resolved
pkg/cert/v1beta1/kube/client.go Outdated Show resolved Hide resolved
@tenzen-y
Copy link
Member Author

/assign

@tenzen-y tenzen-y force-pushed the issue-1656-reimplement-katib-cert-generator branch from 5c50392 to 4e5f95d Compare September 10, 2021 13:52
andreyvelich
andreyvelich reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this @tenzen-y!
I left few comments.

cmd/cert-generator/v1beta1/Dockerfile Show resolved Hide resolved
cmd/cert-generator/v1beta1/Dockerfile Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
manifests/v1beta1/components/cert-generator/cert-generator.yaml Outdated Show resolved Hide resolved
manifests/v1beta1/components/webhook/webhooks.yaml Outdated Show resolved Hide resolved
pkg/cert/v1beta1/generate/generate.go Outdated Show resolved Hide resolved
pkg/cert/v1beta1/generate/generate.go Outdated Show resolved Hide resolved
pkg/cert/v1beta1/generate/generate.go Outdated Show resolved Hide resolved
pkg/cert/v1beta1/generate/generate_test.go Outdated Show resolved Hide resolved
pkg/cert/v1beta1/generate/generate_test.go Outdated Show resolved Hide resolved
@andreyvelich
Copy link
Member

@tenzen-y Is that correct that after this implementation we are not going to use CertificateSigningRequest ?

@andreyvelich
Copy link
Member

/ok-to-test

@tenzen-y tenzen-y force-pushed the issue-1656-reimplement-katib-cert-generator branch from be3bc92 to 0797cd5 Compare September 10, 2021 15:29
@tenzen-y tenzen-y force-pushed the issue-1656-reimplement-katib-cert-generator branch 2 times, most recently from a3ed1c8 to a370da0 Compare September 11, 2021 13:22
@tenzen-y @andreyvelich
review: add comments
9c47bb9 
Co-authored-by: andreyvelich <andrey.velichkevich@gmail.com>
@tenzen-y tenzen-y force-pushed the issue-1656-reimplement-katib-cert-generator branch 2 times, most recently from 52a3ea6 to 45e9123 Compare September 11, 2021 13:48
@tenzen-y
review: remove v1beta1 from admissionReviewVersions in ValidatingWebh…
ebd6ead 
…ookConfiguration and MutatingWebhookConfiguration
@tenzen-y tenzen-y force-pushed the issue-1656-reimplement-katib-cert-generator branch from 45e9123 to ebd6ead Compare September 11, 2021 14:10
@tenzen-y
Copy link
Member Author

/retest

1 similar comment
@tenzen-y
Copy link
Member Author

/retest

@aws-kf-ci-bot
Copy link
Contributor

@tenzen-y: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test kubeflow-katib-presubmit

Use /test all to run all jobs.

In response to this:

/retest t

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y
Copy link
Member Author

/retest

@tenzen-y
Copy link
Member Author

/retest

1 similar comment
@tenzen-y
Copy link
Member Author

/retest

@tenzen-y tenzen-y mentioned this pull request Sep 14, 2021
Open
andreyvelich
andreyvelich reviewed Sep 14, 2021
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution @tenzen-y!
/lgtm
@gaocegege @johnugeorge Please take a look.

gaocegege
gaocegege approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

Thanks for your contribution! 🎉 👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 2a11c35 into kubeflow:master Sep 15, 2021
@tenzen-y
Copy link
Member Author

Thanks for the review! @andreyvelich @johnugeorge @gaocegege

@tenzen-y tenzen-y deleted the issue-1656-reimplement-katib-cert-generator branch September 15, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnugeorge johnugeorge johnugeorge left review comments

@andreyvelich andreyvelich andreyvelich left review comments

@gaocegege gaocegege gaocegege approved these changes

@hougangliu hougangliu Awaiting requested review from hougangliu

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@gaocegege gaocegege

@andreyvelich andreyvelich

@tenzen-y tenzen-y

Labels
approved lgtm ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Katib not ready for K8s 1.22
6 participants
@tenzen-y @aws-kf-ci-bot @gaocegege @andreyvelich @google-oss-robot @johnugeorge