Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution case of IEF #456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add solution case of IEF #456

wants to merge 1 commit into from

Conversation

Shelley-BaoYue
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue commented Nov 11, 2023 •
edited

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

docs update

  • What is the new behavior (if this is a feature change)?

add solution case of Huawei Cloud product Intelligent EdgeFabric(IEF)

@kubeedge-bot kubeedge-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2023
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2023
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 11, 2023
@Shelley-BaoYue Shelley-BaoYue changed the title [wip]add IEF case add solution case of IEF Nov 11, 2023
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2023
fisherxu
fisherxu reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the dir name to IEF :)

@benjaminhuo
Copy link

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@Shelley-BaoYue
Copy link
Collaborator Author

Fix the dir name to IEF :)

fixed.

fisherxu
fisherxu reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@fisherxu
Copy link
Member

/hold
The IEF page link is broken now.. ptal @Shelley-BaoYue

@kubeedge-bot kubeedge-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@Shelley-BaoYue
Copy link
Collaborator Author

/hold The IEF page link is broken now.. ptal @Shelley-BaoYue

A very bad news, it seems that you have to have a corresponding directory under the English directory so that the plugin can recognize Chinese. I will try to find other solutions.

@fisherxu
Copy link
Member

Create a same name dir under English directory is also fine, I think.

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@kubeedge-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benjaminhuo
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shelley-BaoYue
Copy link
Collaborator Author

Create a same name dir under English directory is also fine, I think.

I have added it and IEF case card will be shown in en website as below, but the content is blank 😢
image

@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2023
@Shelley-BaoYue
add IEF case
5e87947 
Signed-off-by: Shelley-BaoYue <baoyue2@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@anvithks anvithks Awaiting requested review from anvithks

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

Assignees

@benjaminhuo benjaminhuo

@fisherxu fisherxu

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shelley-BaoYue @benjaminhuo @fisherxu @kubeedge-bot